Draft
Conversation
Contributor
fredizzimo
commented
Jul 29, 2024
fredizzimo
commented
- Fix the end frame, it was called twice before, and before present. Now it's after present, which matches the wgpu-profiler sample code.
- Disable some high frequency profiling events with too much overhead
End frame was called twice before, and now it also matches the example in wgpu-profiler.
The overhead is a bit too big to keep enabled all the time.
Contributor
Author
|
The duplicate end frame is because Neovide also does it, so this fix is not correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.