Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin: Replace readClusterState with existing watch events #904

Merged
merged 3 commits into from
May 22, 2024
Merged

plugin: Replace readClusterState with existing watch events #904

merged 3 commits into from
May 22, 2024

Commits on May 22, 2024

  1. plugin: Remove vmStore from AutoscaleEnforcer (#904) 

    After the changes from #865 that switched to fetching VmInfo from Pod
objects, the VM store is no longer needed long-term, just during initial
cluster state reading (which can *also* be swapped out) and for event
generation.

This commit changes the VM store from being stored in the
AutoscaleEnforcer struct to being passed in to readClusterState as an
argument.
    @sharnoff
    sharnoff committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8f2061c View commit details
    Browse the repository at this point in the history

  2. plugin: Handle Buffer in reserveResources() (#904)

    @sharnoff
    sharnoff committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f7d101c View commit details
    Browse the repository at this point in the history

  3. plugin: Replace readClusterState with existing watch events (#904) 

    In short, readClusterState is super complicated, separately reimplements
the reserveResources() logic, and may be the source of several
startup-related bugs (probably #671 and #852).

So, given that we *already* have a pathway for updating our internal
state from changes in the cluster (i.e. the watch events), we should
just use that instead.
    @sharnoff
    sharnoff committed May 22, 2024
    Configuration menu
    Copy the full SHA
    ceceb07 View commit details
    Browse the repository at this point in the history