-
-
Notifications
You must be signed in to change notification settings - Fork 7
Add Problem Reporting API and provide Access Transformer Errors in a Machine Readable Format #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Last commit published: 10fa1ef999adccc9c9d8b45b0506c2ddd6d59b70. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #50' // https://github.com/neoforged/JavaSourceTransformer/pull/50
url 'https://prmaven.neoforged.net/JavaSourceTransformer/pr50'
content {
includeModule('net.neoforged.jst', 'jst-api')
includeModule('net.neoforged.jst', 'jst-cli')
includeModule('net.neoforged.jst', 'jst-cli-bundle')
}
}
} |
|
@shartte, this pull request has conflicts, please resolve them for this PR to move forward. |
Matyrobbrt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did not have any of the errors in ApplyATsVisitor (that use this method) changed to the problems system.
| if (e instanceof RuntimeException re) { | ||
| throw re; | ||
| } | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would replace this with a sneaky generic throw, not sure if we have a helper for that in JST.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a friend of that hack tbh. Is there a significant issue with this wrapping?
...ormers/src/main/java/net/neoforged/jst/accesstransformers/AccessTransformersTransformer.java
Show resolved
Hide resolved
...ormers/src/main/java/net/neoforged/jst/accesstransformers/AccessTransformersTransformer.java
Outdated
Show resolved
Hide resolved
accesstransformers/src/main/java/net/neoforged/jst/accesstransformers/ApplyATsVisitor.java
Show resolved
Hide resolved
|
🚀 This PR has been released as JavaSourceTransformer version |
Exposes a Problem Reporting API to plugins, and uses that API to report issues with access transformers.
A new CLI option can be used to get all reported problems in a JSON format.