Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update neo to 3.7.5 #446

Merged
merged 21 commits into from
Jul 4, 2024
Merged

Conversation

chenzhitong
Copy link
Member

No description provided.

src/neoxp/Commands/BatchCommand.BatchFileCommands.cs Outdated Show resolved Hide resolved
src/assertions/assertions.csproj Outdated Show resolved Hide resolved
src/assertions/assertions.csproj Outdated Show resolved Hide resolved
@cschuchardt88
Copy link
Member

You still need to update TestApplicationEngine.

@gsmachado
Copy link

Just to re-iterate: we need this! 🙏

@cschuchardt88
Copy link
Member

@gsmachado Looks like PRs were forgotten in the release of 3.7.5. Going to have to wait until 3.8.0

@steven1227
Copy link
Member

3.8.0 is still long , let us have 3.7.5 first

@gsmachado
Copy link

@cschuchardt88 I don't understand correctly. So, there were PRs required to modify Neo node/core in order to make neo-express work?

Or am I missing something?

@cschuchardt88
Copy link
Member

cschuchardt88 commented Jun 27, 2024

We may release 3.7.6 of neo with missing PRs in order to get a neo-express build.

3.8.0 is still long , let us have 3.7.5 first

ApplicationEngine changed so much, can't do without it.

@steven1227
Copy link
Member

We may release 3.7.6 of neo with missing PRs in order to get a neo-express build.

3.8.0 is still long , let us have 3.7.5 first

ApplicationEngine changed so much, can't do without it.

Let us see if we are ready to have a 3.7.6 @superboyiii

@chenzhitong
Copy link
Member Author

You still need to update TestApplicationEngine.

The two PRs (neo-project/neo#3225 , neo-project/neo#3243) you changed for ApplicationEngine are not in neo 3.7.5. @cschuchardt88

@chenzhitong
Copy link
Member Author

@cschuchardt88 I tried adding the neo submodule and it compiles successfully on my computer, can you help me see why the GitHub action doesn't work?

@cschuchardt88
Copy link
Member

@chenzhitong all fixed

@chenzhitong
Copy link
Member Author

chenzhitong commented Jul 1, 2024

@cschuchardt88 Worship, why did you add the README.md file and the png image and the workflow action worked, what does the .neo folder do.
R

@cschuchardt88
Copy link
Member

Its for submodule, to use.

.github/workflows/publish.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
test/test.bctklib/ReadOnlyStoreTests.cs Show resolved Hide resolved
test/test.bctklib/CodeCoverageTests.cs Show resolved Hide resolved
src/assertions/assertions.csproj Show resolved Hide resolved
src/Directory.Build.props Outdated Show resolved Hide resolved
@cschuchardt88 cschuchardt88 merged commit b20ddc9 into neo-project:master Jul 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants