Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [BREAKING] make use of the new action cache #2509

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented Oct 29, 2024

Breaking

  • removal of old backend
  • removal of cli flag
  • migrated tests
  • frees up storage of old backend

Fixes

  • remote docker actions corrected to pass tests

Tracked in #2472

* removal of old backend
* migrated tests
Copy link
Contributor

github-actions bot commented Oct 29, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 11 0 0.06s
✅ REPOSITORY gitleaks yes no 2.37s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 9.22s
✅ REPOSITORY secretlint yes no 1.09s
✅ REPOSITORY trivy-sbom yes no 0.11s
✅ REPOSITORY trufflehog yes no 3.32s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@pull-request-size pull-request-size bot added size/L and removed size/XL labels Nov 2, 2024
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 70.42254% with 21 lines in your changes missing coverage. Please review.

Project coverage is 75.07%. Comparing base (5a80a04) to head (f875732).
Report is 127 commits behind head on master.

Files with missing lines Patch % Lines
pkg/runner/step_action_remote.go 68.75% 7 Missing and 3 partials ⚠️
pkg/runner/action.go 60.00% 7 Missing and 1 partial ⚠️
pkg/container/host_environment.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2509       +/-   ##
===========================================
+ Coverage   61.56%   75.07%   +13.50%     
===========================================
  Files          53       62        +9     
  Lines        9002     9984      +982     
===========================================
+ Hits         5542     7495     +1953     
+ Misses       3020     1912     -1108     
- Partials      440      577      +137     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristopherHX
Copy link
Contributor Author

TLDR I break everything

I consider backporting the code fixes of the new-action-cache before implementing cleanup of old cache

@ChristopherHX ChristopherHX marked this pull request as ready for review November 3, 2024 00:22
@ChristopherHX ChristopherHX requested a review from a team as a code owner November 3, 2024 00:22
@ChristopherHX
Copy link
Contributor Author

Backport of code fixes doesn't fulfill coverage, but this one does.

@ChristopherHX ChristopherHX changed the title feat: make use of the new action cache feat: [BREAKING] make use of the new action cache Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make --use-new-action-cache the new default for downloading actions
1 participant