가입 승인제 PR 보강 #28
Merged
가입 승인제 PR 보강 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
번역 추가했으나 https://pr-28.test.nekoplanet.xyz/assets/locales/en-US.2024.11.0+neko-rc.json 에는 여전히 일본어가 보이네..? |
- yaml config 에서 approvalRequiredForSignup 제거 - config을 사용하고 있던 부분을 제거하고, DB의 설정값을 대신 사용 - MkVisitorDashboard 에서 approvalRequiredForSignup 에 따라 컨트롤이 가입 버튼이 다르게 보이도록 - 제어판에서 approvalRequiredForSignup 을 켜면 켜지도록
seojangho
force-pushed
the
update/24.11.0-fix-approval
branch
from
73bbb80 to
743440a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #27