Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit test suite Workflow to only run on changes to Python files #1884

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shenanigansd
Copy link

@shenanigansd shenanigansd commented Oct 22, 2024

Add a filter to testsuite.yml to only run when .py files are changed.

This should cleanly coexist with the existing branch filter:

If you define both branches/branches-ignore and paths/paths-ignore, the workflow will only run when both filters are satisfied.
- https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore

ref: https://discord.com/channels/267624335836053506/1253355750684753950/1298279250830557236

@shenanigansd
Copy link
Author

Hmm, tests are a required check. Since we skipped them, that check will never pass. This is awkward.

@nedbat
Copy link
Owner

nedbat commented Oct 22, 2024

The tests are skipped if the branch is named *notests*, can we use the same mechanism?

@shenanigansd shenanigansd marked this pull request as draft October 22, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants