GradleLintPluginTaskConfigurer: criticalLintGradle should depend on A…

…bstractCompile tasks, similar to other lint tasks
nebula-plugins · Oct 28, 2024 · 4d51fbb · 4d51fbb
1 parent 5718c61
commit 4d51fbb
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 0 deletions.
diff --git a/src/main/groovy/com/netflix/nebula/lint/plugin/GradleLintPluginTaskConfigurer.groovy b/src/main/groovy/com/netflix/nebula/lint/plugin/GradleLintPluginTaskConfigurer.groovy
@@ -115,6 +115,12 @@ class GradleLintPluginTaskConfigurer extends AbstractLintPluginTaskConfigurer {
                     fixLintGradleTask.dependsOn(project.tasks.withType(AbstractCompile))
                 }
             })
+            project.rootProject.tasks.named(CRITICAL_LINT_GRADLE).configure(new Action<Task>() {
+                @Override
+                void execute(Task criticalLintGradle) {
+                    criticalLintGradle.dependsOn(project.tasks.withType(AbstractCompile))
+                }
+            })
         }
     }
 

diff --git a/src/test/groovy/com/netflix/nebula/lint/plugin/GradleLintPluginSpec.groovy b/src/test/groovy/com/netflix/nebula/lint/plugin/GradleLintPluginSpec.groovy
@@ -347,6 +347,10 @@ class GradleLintPluginSpec extends BaseIntegrationTestKitSpec {
                 id 'java'
             }
 
+            repositories {
+               mavenCentral()
+            }
+            
             gradleLint.rules = ['dependency-parentheses']
             gradleLint.criticalRules = ['dependency-tuple']
 
@@ -370,6 +374,45 @@ class GradleLintPluginSpec extends BaseIntegrationTestKitSpec {
         console.every { ! it.contains('dependency-parentheses') }
     }
 
+
+    def 'critical lint depends on compilation tasks'() {
+        given:
+        buildFile << """
+            plugins {
+                id 'nebula.lint'
+                id 'java'
+            }
+
+            repositories {
+                mavenCentral()
+            }
+            
+            gradleLint.rules = ['dependency-parentheses']
+            gradleLint.criticalRules = ['dependency-tuple']
+
+            dependencies {
+                implementation('com.google.guava:guava:18.0')
+                testImplementation group: 'junit',
+                    name: 'junit',
+                    version: '4.11'
+            }
+        """
+        disableConfigurationCache()
+        writeHelloWorld()
+
+        when:
+        def results = runTasksAndFail('criticalLintGradle')
+
+        then:
+        def console = results.output.readLines()
+        console.findAll { it.startsWith('error') }.size() == 1
+        console.any { it.contains('dependency-tuple') }
+        console.every { ! it.contains('dependency-parentheses') }
+
+        and:
+        results.task(':classes').outcome in [TaskOutcome.SUCCESS, TaskOutcome.UP_TO_DATE, TaskOutcome.FROM_CACHE]
+    }
+
     @Unroll
     def 'auto correct all violations on a single module project with task #taskName'() {
         when: