Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compilation of synth-bm #12898

Merged
merged 2 commits into from
Feb 10, 2025
Merged

fix compilation of synth-bm #12898

merged 2 commits into from
Feb 10, 2025

Conversation

ssavenko-near
Copy link
Contributor

The project does not compile on current master.
Most probably this issue sneaked in due to auto-merging of recent commits.

The project does not compile on current master.
Most probably this issue sneadked in due to auto-merging of recent commits.
@ssavenko-near ssavenko-near requested a review from mooori February 10, 2025 13:21
@ssavenko-near ssavenko-near marked this pull request as ready for review February 10, 2025 13:21
@ssavenko-near ssavenko-near requested a review from a team as a code owner February 10, 2025 13:21
@ssavenko-near ssavenko-near requested a review from wacban February 10, 2025 13:21
@ssavenko-near ssavenko-near reopened this Feb 10, 2025
Copy link
Contributor

@wacban wacban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

You may want to add some CI for this tool.

@ssavenko-near ssavenko-near added this pull request to the merge queue Feb 10, 2025
@mooori
Copy link
Contributor

mooori commented Feb 10, 2025

Issues like that should fail CI once synth-bm is included in the root workspace: #12887

Merged via the queue into master with commit 5ddd776 Feb 10, 2025
30 of 48 checks passed
@ssavenko-near ssavenko-near deleted the slavas/bm-fix branch February 10, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants