Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench(synth-bm): make binary selection more explicit #12897

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mooori
Copy link
Contributor

@mooori mooori commented Feb 10, 2025

Replaces #12817 where resolving merge conflicts has gone wrong.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.54%. Comparing base (0e21730) to head (bd09233).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12897      +/-   ##
==========================================
- Coverage   70.54%   70.54%   -0.01%     
==========================================
  Files         851      851              
  Lines      174914   174914              
  Branches   174914   174914              
==========================================
- Hits       123395   123385      -10     
- Misses      46397    46405       +8     
- Partials     5122     5124       +2     
Flag Coverage Δ
backward-compatibility 0.36% <ø> (ø)
db-migration 0.36% <ø> (ø)
genesis-check 1.42% <ø> (ø)
linux 70.40% <ø> (+<0.01%) ⬆️
linux-nightly 70.16% <ø> (-0.03%) ⬇️
pytests 1.73% <ø> (ø)
sanity-checks 1.54% <ø> (ø)
unittests 70.37% <ø> (-0.01%) ⬇️
upgradability 0.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mooori mooori requested review from akhi3030 and Trisfald February 12, 2025 11:56
@mooori mooori marked this pull request as ready for review February 12, 2025 11:56
@mooori mooori requested a review from a team as a code owner February 12, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant