feat(core/time): Add comprehensive tests and documentation for Clock … #12860
+144
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…implementation - Add usage examples and detailed API documentation - Implement test suite for real and fake clock functionality - Document cancellation behavior and time characteristics - Remove TODO comment by implementing missing tests
akhi3030
approved these changes
Feb 10, 2025
auto-merge was automatically disabled
February 10, 2025 15:13
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
February 10, 2025 19:47
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
February 11, 2025 15:09
Head branch was pushed to by a user without write access
|
@akhi3030 Corrected everything |
akhi3030
reviewed
Feb 11, 2025
|
@akhi3030 resolved |
akhi3030
reviewed
Feb 12, 2025
akhi3030
reviewed
Feb 12, 2025
core/time/src/clock.rs
Outdated
Comment on lines
226
to
228
| if inner.now() >= deadline { | ||
| return; | ||
| } |
There was a problem hiding this comment.
This check seems unnecessary as in it will be quite rarely hit. deadline is now + d. And we know that d is not 0 so chances of this condition being true should be only when the process gets interrupted in between computing deadline and this line which should be quite rare. So I would say we can remove it.
akhi3030
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…implementation