Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable implied extensions #1619

Merged
merged 1 commit into from
Dec 15, 2024
Merged

enable implied extensions #1619

merged 1 commit into from
Dec 15, 2024

Conversation

shayne-fletcher
Copy link
Collaborator

this is an attempt at a fix for #1604. the idea is to make use of extensionImplications

T.hs

import Language.Haskell.TH

oneC, twoC, plusC  :: Quote m => m Exp
oneC = [| 1 |]
twoC = [| 2 |]
plusC = [| $oneC + $twoC |]

main = pure ()

T.hs compiled with cabal run exe:hlint -- -XGHC2021 -XTemplateHaskell ~/RRR.hs fails for lack of HaskellTemplateQuotes before this fix and succeeds after.

Copy link
Collaborator

@zliu41 zliu41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some overlap with parts of src/Extension.hs.

src/GHC/All.hs Show resolved Hide resolved
@shayne-fletcher shayne-fletcher marked this pull request as draft December 13, 2024 21:51
@shayne-fletcher shayne-fletcher marked this pull request as ready for review December 14, 2024 20:12
@shayne-fletcher shayne-fletcher merged commit 7b7db9d into master Dec 15, 2024
10 checks passed
@shayne-fletcher shayne-fletcher deleted the sf-fix-1604 branch December 15, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants