Update Store and TTL implementation #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelvalle
commented
Sep 23, 2024
| /// Only set the key if it does not already exist. | ||
| Nx, | ||
| /// Only set the key if it already exists. | ||
| Xx, |
There was a problem hiding this comment.
So we can have these on cargo docs.
ndelvalle
commented
Sep 23, 2024
| } | ||
| pub struct InnerStoreLocked<'a> { | ||
| state: MutexGuard<'a, State>, | ||
| waker: &'a Notify, |
There was a problem hiding this comment.
store.lock() returns an InnerStoreLocked wrapper type, which acts like a transaction. While this struct is held, all operations occur on the locked store, ensuring no other changes can occur concurrently. This is particularly useful for methods like SET, where a value may need to be read and then updated—allowing you to avoid locking the store multiple times by reusing the locked state.
However, it’s important to release the InnerStoreLocked as soon as possible, since holding it for longer than necessary blocks access to the store’s state for other operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.