Fix #1694: Remove infinite recursion in manage_object function #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unnecessary recursive calls in manage_object function - Add proper callback handling for both dict and object cases - Add comprehensive test suite to verify functionality - Improve documentation and type hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the infinite recursion issue in the manage_object function by:
Removing unnecessary recursive calls in manage_object function
Adding proper callback handling for both dict and object cases
Adding comprehensive test suite to verify functionality
Improving documentation and type hints
The changes have been tested and all tests are passing. The fix ensures that the manage_object function now properly handles both dictionary and object cases without causing infinite recursion, while maintaining the expected behavior of not overwriting existing values.
Fixes #1694