Fix remote pull ontology process for zipped submissions #55
Open
syphax-bouazzouni wants to merge 12 commits intoncbo:developfrom
Open
Fix remote pull ontology process for zipped submissions #55syphax-bouazzouni wants to merge 12 commits intoncbo:developfrom
syphax-bouazzouni wants to merge 12 commits intoncbo:developfrom
Conversation
syphax-bouazzouni
changed the title
syphax-bouazzouni
force-pushed
the
pr/fix-zipped-sumbission-remote-pull
branch
from
eca22b2 to
981bc2a
Compare
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 53.95% 54.38% +0.42%
==========================================
Files 15 15
Lines 1214 1210 -4
==========================================
+ Hits 655 658 +3
+ Misses 559 552 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix
The do_remote_ontology_pull that fetches and parses new versions of ontologies if found. Does not work for zipped submissions.
It's because before creating a new submission, it checks if OWLAPI can parse the new file. But this test does not work for ZIP/GZIP files.
related