Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seenAlready must drop older events #112

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Conversation

mattn
Copy link
Contributor

@mattn mattn commented Nov 24, 2023

seenAlready is used to avoid duplicate events receiving at different times from multiple relays, but if left unchecked, memory will gradually be used; old events should be deleted after a certain period of time as they never arrive after EOSE is given.

Copy link

sweep-ai bot commented Nov 24, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@mattn mattn changed the title [WIP] seenAlready must drop older events seenAlready must drop older events Nov 24, 2023
@fiatjaf fiatjaf merged commit cd0d644 into nbd-wtf:master Nov 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants