Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing depreceated return of methods LoadAnnotationService::process and NzoUrIEncryptorBundle::build #73

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

lucasfoussier
Copy link
Contributor

@lucasfoussier lucasfoussier commented Jan 20, 2024

With the latest Symfony versions, we have some depreceated reported in logs :

deprecation Method "Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface::process()" might add "void" as a native return type declaration in the future. Do the same in implementation "Nzo\UrlEncryptorBundle\DependencyInjection\Compiler\LoadAnnotationService" now to avoid errors or add an explicit @return annotation to suppress this message.
deprecation User Deprecated: Method "Symfony\Component\HttpKernel\Bundle\Bundle::build()" might add "void" as a native return type declaration in the future. Do the same in child class "Nzo\UrlEncryptorBundle\NzoUrlEncryptorBundle" now to avoid errors or add an explicit @return annotation to suppress this message.

To fix this, adding the return type void to the following methods fix the issues :

  • Nzo\UrlEncryptorBundle\DependencyInjection\Compiler\LoadAnnotationService::process
  • Nzo\UrlEncryptorBundle\NzoUrlEncryptorBundle::build

Because of the required php version ^7.1.3 of the bundle and this PR similiraty with #67 it shoud be harmless for all the users of the bundle.

@nayzo nayzo merged commit 10720d6 into nayzo:master Jan 24, 2024
8 checks passed
@nayzo
Copy link
Owner

nayzo commented Jan 24, 2024

@lucasfoussier Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants