Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port market order filling for OrderMatchingEngine in Rust #2202

Merged
merged 3 commits into from
Jan 12, 2025
Merged

Port market order filling for OrderMatchingEngine in Rust #2202

merged 3 commits into from
Jan 12, 2025
+573 −58

Conversation

filipmacek
Copy link
Member

@filipmacek filipmacek commented Jan 10, 2025 •
edited
Loading

Pull Request

  • implements market order fill flow in OrderMatchingEngine

@filipmacek filipmacek added the rust Relating to the Rust core label Jan 10, 2025
@filipmacek filipmacek requested a review from cjdsellers January 10, 2025 15:17
@filipmacek filipmacek self-assigned this Jan 10, 2025
@cjdsellers cjdsellers changed the title Implement market order filling for OrderMatchingEngine in Rust Port market order filling for OrderMatchingEngine in Rust Jan 10, 2025
@filipmacek filipmacek force-pushed the order-matching-engine-fill-market-order branch from 22adbe5 to 5b64373 Compare January 12, 2025 14:18
@filipmacek filipmacek marked this pull request as ready for review January 12, 2025 15:14
cjdsellers
cjdsellers approved these changes Jan 12, 2025
View reviewed changes
Copy link
Member

@cjdsellers cjdsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@cjdsellers cjdsellers merged commit 1585af0 into develop Jan 12, 2025
11 checks passed
@cjdsellers cjdsellers deleted the order-matching-engine-fill-market-order branch January 12, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjdsellers cjdsellers cjdsellers approved these changes

Assignees

@filipmacek filipmacek

Labels
rust Relating to the Rust core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipmacek @cjdsellers