Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes: #921

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Minor fixes: #921

wants to merge 3 commits into from

Conversation

JimBayne
Copy link

@JimBayne JimBayne commented Jul 8, 2022

I've been using these 2 fixes since release 1.8. Thought they might be of use.

Fix 1) WaveFileWriter:

  • Don't dispose of memory streams in the Finalizer. It deletes them (which defeats WaveFileWriter's purpose)

Fix 2) Mp3FileReader.ReadNextFrame:

  • Don't try to read from a closed stream.
  • Was happening intermittently in the past (probably due to some sort of timing + multi tasking issue)

Many thanks for this wonderful library.

@JimBayne JimBayne closed this Jul 8, 2022
@JimBayne JimBayne reopened this Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant