Core - Improvements to i18n #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internal translations are in en-US at the moment. The source code for built-in views and other core elements are not updated to use this yet.
All - replaced _i18n with _internal when needed i18n - Moved for loop for loadLocale into a new function i18n - Made loadInternal public to other files (mostly for Application)
i18n - Slightly changed how internalXML was defined i18n - Added too much comments GLFW Platform - Added method to get locale (might work on certain platforms) Scripts - Remove i18n-linter
i18n - Comment improvements Application - Info message improvements
Resources - Converted demo.json to demo.xml Box - Using BRLS_ASSET instead of manual method
All - clang-format
This includes adding the folly library (only on GLFW right now) and boost preprocessor library (required for folly)
|
I like how I replaced a fatty library with a even more fatty library |
EmmmaTech
changed the title
All - Clang-Format GLFW Platform - Changed error message of incompatible locale to mention the locale
|
No, I downloaded the 2021.03.22.00 release, It should be a subrepo |
…xtern/folly subrepo: subdir: "library/lib/extern/folly" merged: "09cc63cb9" upstream: origin: "https://github.com/facebook/folly.git" branch: "master" commit: "09cc63cb9" git-subrepo: version: "0.4.3" origin: "https://github.com/ingydotnet/git-subrepo" commit: "2f68596"
|
Okay done. It's now a subrepo! Also, just so you can know, the Switch build still uses |
|
Couldn't get what to build? F14FastMap?
Le 2 avril 2021 17:12:58 EmreTech ***@***.***> a écrit :
…
Okay done. It's now a subrepo! Also, just so you can know, the Switch build
still uses std::unordered_map. IIRC, I couldn't get it to build, so GLFW
will be using F14FastMap for now.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Yeah. It freaks out after it can't find file |
EmmmaTech
changed the title
|
I decided to remove Folly because the library is too big and we're only using it for one purpose. Someone else can add it back later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #127 and #130, all in one Pull Request.
This Pull Request aims to improves i18n and BRLS_ASSET.
Features implemented before this PR was made:
To-do with this Pull Request:
What's finished: