Add zero-copy key serialization to RocksDB state backend#1
Open
nateab wants to merge 1 commit intofeature/rocksdb-bytebuffer-optimizationfrom
Open
Add zero-copy key serialization to RocksDB state backend#1nateab wants to merge 1 commit intofeature/rocksdb-bytebuffer-optimizationfrom
nateab wants to merge 1 commit intofeature/rocksdb-bytebuffer-optimizationfrom
Conversation
This extends the ByteBuffer optimization from PR apache#27524 to key serialization, avoiding Arrays.copyOf() allocation for composite keys in RocksDB state operations. Changes: - Add buildCompositeKeyNamespaceToByteBuffer() and related methods to SerializedCompositeKeyBuilder - Add serializeCurrentKeyWithGroupAndNamespaceToByteBuffer() to AbstractRocksDBState - Update RocksDBValueState.update() to use zero-copy key serialization - Update RocksDBMapState.put() to use zero-copy key serialization - Update AbstractRocksDBAppendingState.updateInternal() for zero-copy Benchmark results show: - 90-97% allocation reduction for key serialization - GC collections reduced to zero in benchmarks - Combined with value optimization: >100 MB/s allocation eliminated Safety: Same thread-safety model as value optimization - RocksDB operations are synchronous and copy data before returning, making buffer reuse safe in Flink's single-threaded mailbox execution. Note: WriteBatch operations still use byte[] as shared buffers are unsafe with deferred writes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends the ByteBuffer optimization from PR apache#27524 to key serialization, avoiding Arrays.copyOf() allocation for composite keys in RocksDB state operations.
Changes:
Benchmark results show:
Safety: Same thread-safety model as value optimization - RocksDB operations are synchronous and copy data before returning, making buffer reuse safe in Flink's single-threaded mailbox execution.
Note: WriteBatch operations still use byte[] as shared buffers are unsafe with deferred writes.
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation