Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for 5 models #1776

Merged
merged 12 commits into from
Feb 7, 2025
Merged

Conversation

claire-simpson
Copy link
Contributor

Description

I've added unit tests for Annual Water Yield, Carbon, Blue Carbon, Coastal Vulnerability, and Crop Production (regression). These tests assume that the functions we have currently are producing the correct output.

Fixes #1603 (in part)

Checklist

  • Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
  • Updated the user's guide (if needed)
  • Tested the Workbench UI (if relevant)

@claire-simpson claire-simpson changed the title Add unit tests for Add unit tests for 5 models Feb 6, 2025
@claire-simpson claire-simpson requested a review from emlys February 6, 2025 20:36
Copy link
Member

@emlys emlys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks @claire-simpson! This must have taken a lot of work and it's going to make these test suites much more comprehensive. My only suggestion would be: if we update test suites for more models and find that the helper functions for creating test data, checking results, etc become redundant, should we abstract those out to a test_utilities module? But I don't think that needs to happen in this PR.

@emlys emlys merged commit 347c7a0 into natcap:main Feb 7, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more unit tests for models that could use them
2 participants