More fixes to String#inspect #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase the data type to support multibyte chars.
It still isn't perfect, but this gets 2 more specs running. The failing specs imply the behaviour depends on the character encoding, so we should probably move the inner loop of inspect from StringObject to EncodingObject.
Add a default implementation that works for ASCII ranges.
This one makes sure we print the extended characters for unicode strings.
seven1m
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1840
The decision whether a character should be escaped is moved from StringObject to EncodingObject, this needs to be encoding aware too. Only UTF8 has a sensible printable member function, all other encodings work according to the specs (which probably means there are no specs).
This fixes the YAML escape issue mentioned in #1839 as well, running the full upstream specs of
String#dumpandString#inspectnow results in valid YAML output, so the issue with spec results not showing up in the overview should be resolved as well (the double free issue with the YAML lib is still relevant though)