Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trick prints warning for checkpoints outside of freeze mode. #1682

Conversation

Mrockwell2
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Mar 29, 2024

Coverage Status

coverage: 56.182% (+0.2%) from 55.952%
when pulling e538aec on Mrockwell2:1461-only-allow-dumping-and-loading-checkpoints-in-freeze-mode
into d72312c on nasa:master.

@excaliburtb
Copy link
Contributor

i don't think this is true for generic cases. if you have some fully async threads running, then it might be a problem. otherwise, it is well-defined behavior. Perhaps you have a specific use case or example that illustrates the issue?

@Mrockwell2
Copy link
Contributor Author

i don't think this is true for generic cases. if you have some fully async threads running, then it might be a problem. otherwise, it is well-defined behavior. Perhaps you have a specific use case or example that illustrates the issue?

When you checkpoint a running sim without freezing and reload that checkpoint, the data recording log resumes on the next frame. So far that's the most glaring thing I've found, but I'll keep looking.

@Mrockwell2 Mrockwell2 closed this May 31, 2024
@Mrockwell2
Copy link
Contributor Author

The issue fix was better implemented in another branch. See this pull request (#1727 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants