-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve telemetry buffering implementation #7837
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7837 +/- ##
==========================================
- Coverage 57.25% 57.00% -0.25%
==========================================
Files 675 675
Lines 27287 27317 +30
Branches 2671 2671
==========================================
- Hits 15622 15572 -50
- Misses 11329 11409 +80
Partials 336 336
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I would consider moving the the addEventListener('DOMContentLoaded' approach
- Don't declare the const locators if the variable is only read once
- Consider a regular label instead of aria or use arialabeledby
e2e/tests/functional/plugins/performanceIndicator/performanceIndicator.e2e.spec.js
Show resolved
Hide resolved
e2e/tests/functional/plugins/performanceIndicator/performanceIndicator.e2e.spec.js
Outdated
Show resolved
Hide resolved
b8ad40e
to
6749bcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes. Looks good otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Yay for tests!
Closes #7838
Describe your changes:
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist