[Example User Provider] Fix inability to get to example login form #7728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…well as return possible roles after login promise has resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7728 +/- ##
==========================================
- Coverage 56.87% 56.57% -0.31%
==========================================
Files 673 673
Lines 27182 27183 +1
Branches 2635 2635
==========================================
- Hits 15461 15380 -81
- Misses 11390 11472 +82
Partials 331 331
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -141,7 +141,7 @@ export default class ExampleUserProvider extends EventEmitter { | |||
| } | |||
|
|
|||
| getPossibleRoles() { | |||
| return this.user.getRoles(); | |||
| return this.loginPromise.then(() => this.user.getRoles()); | |||
There was a problem hiding this comment.
Normal practise, is to use underscore (_) as a parameter in the promise constructor. Just a nitpick
There was a problem hiding this comment.
Given that the argument is unused
|
Tests, please. Nothing should be pushed any more without tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7727
Describe your changes:
Changed how we assign defaults for the argument object. In
getPossibleRoleswait for login promise to resolve, before accessing the user object.All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist