Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workers for webpack 5 #7722

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

ozyx
Copy link
Member

@ozyx ozyx commented May 10, 2024

Closes

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

self.onmessage = function handleMessage(event) {
var message = event.data;
var handler = handlers[message.request];
self.onmessage = (event) => {

Check warning

Code scanning / CodeQL

Missing origin verification in `postMessage` handler Medium

Postmessage handler has no origin check.
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.56%. Comparing base (810d580) to head (b597b75).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7722      +/-   ##
==========================================
+ Coverage   56.87%   60.56%   +3.69%     
==========================================
  Files         673      431     -242     
  Lines       27182    13513   -13669     
  Branches     2635        0    -2635     
==========================================
- Hits        15459     8184    -7275     
+ Misses      11392     5329    -6063     
+ Partials      331        0     -331     
Flag Coverage Δ
e2e-full 23.55% <100.00%> (-17.99%) ⬇️
e2e-stable 60.47% <100.00%> (-0.01%) ⬇️
unit ?
Files Coverage Δ
example/generator/WorkerInterface.js 97.50% <100.00%> (-0.07%) ⬇️
src/api/objects/InMemorySearchProvider.js 59.06% <100.00%> (-35.38%) ⬇️
...c/plugins/persistence/couch/CouchObjectProvider.js 6.54% <ø> (-81.29%) ⬇️

... and 374 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 810d580...b597b75. Read the comment docs.

sharedWorker = new SharedWorker(
sharedWorkerURL,
/* webpackChunkName: "couchDBChangesFeed" */ new URL(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff!

@evenstensberg
Copy link
Contributor

@ozyx if you need anything from webpack side of things for this to land, let me know! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants