HARMONY-1942: Add optional use of krelay for port forwarding #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-durbin
approved these changes
Jan 20, 2025
bin/port-forward
Outdated
| if [ "$USE_KRELAY" == "true" ]; then | ||
| echo "Using krelay to set up port forwarding for $service_name" | ||
| nohup kubectl relay "service/${service_name}" "${args[@]}" -n harmony > "logs/port-forward-${service_name}.log" 2>&1 & | ||
| # krelay does not have a good way to indicate that it is ready, so we have to restort to this for right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue ID
HARMONY-1942
Description
This PR adds support for using krelay to handle port-forwarding. The primary advantage to
krelayis that port forwarding will survive pod restarts. Usingkrelayis optional (controlled by the USE_KRELAY env var), and defaults to not using it.Local Test Steps
krelaykubectlork9sto kill off the harmony podPR Acceptance Checklist
Tests added/updated (if needed) and passing