Skip to content

Conversation

@Czaki
Copy link
Contributor

@Czaki Czaki commented Sep 25, 2025

No description provided.

@Czaki Czaki marked this pull request as ready for review September 25, 2025 09:39
Copy link

@brisvag brisvag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, this is basically a copy of the parts removed from napari/napari#8308?

Should we use the hash-based versioning for actions that we have there?

@Czaki
Copy link
Contributor Author

Czaki commented Sep 25, 2025

If I understand correctly, this is basically a copy of the parts removed from napari/napari#8308?

Almost, it get selection of target from napari/docs#850

Should we use the hash-based versioning for actions that we have there?

As a target, yes.

Copy link

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Czaki @brisvag I really like this approach as it simplifies things. Is it possible to use uv?

with:
qt: true
wm: herbstluftwm
- name: Install dependencies

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use uv in these builds?

@Czaki
Copy link
Contributor Author

Czaki commented Sep 25, 2025

We may migrate this to uv

@Czaki
Copy link
Contributor Author

Czaki commented Sep 25, 2025

@willingc It is using uv now.

Copy link

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Czaki. I like the approach.

@brisvag
Copy link

brisvag commented Sep 26, 2025

Love it!

Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this idea. Can we do the same for the circleci workflow?

Is there any way to test? If it's too complicated though I'm happy with just merging and fixing if it fails.

@Czaki
Copy link
Contributor Author

Czaki commented Sep 26, 2025

@melissawm Maybe we may investigate the dynamic configurations:
https://circleci.com/docs/guides/orchestrate/using-dynamic-configuration/

And just wget it from shared workflows.

@Czaki Czaki merged commit 3fc0e63 into main Sep 26, 2025
1 check passed
@Czaki Czaki deleted the build_docs branch September 26, 2025 18:47
brisvag pushed a commit to napari/napari that referenced this pull request Sep 26, 2025
# References and relevant issues

#8307
Depends on napari/shared-workflows#2

# Description

Instead of syncing workflows, use one shared
brisvag pushed a commit to napari/docs that referenced this pull request Sep 26, 2025
# References and relevant issues

depends on napari/shared-workflows#2

# Description

To reduce synchronization effort, just move build docs to shared
workflows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants