-
Notifications
You must be signed in to change notification settings - Fork 2
Add shared workflow for build docs #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
brisvag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, this is basically a copy of the parts removed from napari/napari#8308?
Should we use the hash-based versioning for actions that we have there?
Almost, it get selection of target from napari/docs#850
As a target, yes. |
willingc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| with: | ||
| qt: true | ||
| wm: herbstluftwm | ||
| - name: Install dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use uv in these builds?
|
We may migrate this to |
|
@willingc It is using uv now. |
willingc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Czaki. I like the approach.
|
Love it! |
melissawm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this idea. Can we do the same for the circleci workflow?
Is there any way to test? If it's too complicated though I'm happy with just merging and fixing if it fails.
|
@melissawm Maybe we may investigate the dynamic configurations: And just wget it from shared workflows. |
# References and relevant issues #8307 Depends on napari/shared-workflows#2 # Description Instead of syncing workflows, use one shared
# References and relevant issues depends on napari/shared-workflows#2 # Description To reduce synchronization effort, just move build docs to shared workflows.
No description provided.