Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate atomic name trading docs from wiki #464

Merged
merged 5 commits into from
Nov 24, 2019

Conversation

JeremyRand
Copy link
Member

Based on #294

@JeremyRand
Copy link
Member Author

@domob1812 Any chance you could review this?

Copy link

@domob1812 domob1812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6fdfd98. I've added some comments, mostly concerning things that got out of date over time due to interface changes.

docs/name-owners/atomic-name-trading/index.md Outdated Show resolved Hide resolved
docs/name-owners/atomic-name-trading/index.md Outdated Show resolved Hide resolved
docs/name-owners/atomic-name-trading/index.md Show resolved Hide resolved
docs/name-owners/atomic-name-trading/index.md Show resolved Hide resolved
docs/name-owners/atomic-name-trading/index.md Outdated Show resolved Hide resolved
docs/name-owners/atomic-name-trading/index.md Outdated Show resolved Hide resolved
docs/name-owners/atomic-name-trading/index.md Outdated Show resolved Hide resolved
docs/name-owners/atomic-name-trading/index.md Outdated Show resolved Hide resolved
@JeremyRand
Copy link
Member Author

@domob1812 Everything look okay now? (A couple of your suggestions I wasn't able to do myself as I'm not super familiar with the RPC commands in question; I'd happily take a follow-up PR from you for this though.)

@domob1812
Copy link

ACK 84af996. I agree that we can do the non-trivial changes in a follow-up. I can work on this myself if you prefer that.

JeremyRand added a commit that referenced this pull request Nov 24, 2019
84af996 Atomic name trading: Fix formatting/typo issues (JeremyRand)
6fdfd98 Move Atomic Name Trading link from header to name-owners docs (JeremyRand)
0157457 Atomic name trading docs: Move to subfolder of Docs for name owners (JeremyRand)
8f606e4 Atomic Name Trading docs: remove hyphen from title (JeremyRand)
862c8d7 Added Atomic Name-Trading (JeremyRand)

Pull request description:

  Based on #294
@JeremyRand JeremyRand merged commit 84af996 into namecoin:master Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants