append changelog to fulfill the license obligation #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reminding about missing "notices" for modifications on original work (violation of GPL-3.0)
Hello,
[Modification terms and conditions in license] The original work should be honored while the modifications on it should be attached with prominent notices as the license GPL-3.0 dictates. Your project is a forking project from Kr328/ClashForAndroid which adopts GPL-3.0 as its project license.
The modification terms and conditions of GPL-3.0 dictate that:
Therefore, we think the project is obligated to abide by the modification terms and conditions in GPL-3.0.
[Violation of modification terms and conditions] We run through your history, and it turns out that you have conducted modifications to the source files of original work while didn't provide prominent notices.
You have 7 commits which conduct modifications to the files of original work, all of which are not declared in README.md.
According to the license terms and conditions above, it is regarded as license violation.
Thus, to avoid potential legal risks, I would suggest you carry out prominent notices for the 7 commits.
[Recommended Fix] There are 2 recommended solutions to fulfill the modification related obligation of GPL-3.0:
Git Mechanism.
Changelog Text.
Or add changelog for modification to comply with the license.
For your convenience, I created a PR with by picking up modification-related commit messages. It adds a few lines in changelog without touching the codebase. Please be comfortable to check it out.
Full details of the report you could refer to the html file attached.
Hope it helps!
If there is anything wrong in this reminding, I'm sorry for my bothering, and please feel free to close this PR.
Cheers!