Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.apache.httpcomponents.client5:httpclient5 from 5.2.1 to 5.2.2 #393

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 24, 2023

Bumps org.apache.httpcomponents.client5:httpclient5 from 5.2.1 to 5.2.2.

Changelog

Sourced from org.apache.httpcomponents.client5:httpclient5's changelog.

Release 5.2.2

This is a maintenance release that fixes several minor defects found since release 5.2.1 and upgrades HttpCore to version 5.2.3.

Change Log

  • HTTPCLIENT-2302: Add comment to TrustStrategy usage in examples (#492). Contributed by Marcono1234

  • More consistent handling of OperationTimeoutException in MemcachedHttpCacheStorage. Contributed by Oleg Kalnichevski

  • HTTPCLIENT-2300: Abstract char message consumers to use UTF-8 by default if a charset has not been explicitly specified by the Content-Type. Contributed by Oleg Kalnichevski

  • HTTPCLIENT-2299: Socket timeout value set via DefaultManagedHttpClientConnection#setSocketTimeout is not correctly persisted and can be overwritten upon connection activation. Contributed by Oleg Kalnichevski

  • Upgraded HttpCore to version 5.2.3. Contributed by Oleg Kalnichevski

  • HTTPCLIENT-2292: HttpClient ignores socketConfig#getSocksProxyAddress. Contributed by Oleg Kalnichevski

  • Allows setting connection timeToLive and validateAfterInactivity to zero to always close or validate a connection. Contributed by Christoph Kaser

  • HTTPCLIENT-2271: Do not optimize the path component of the resolved URI by default. Contributed by Oleg Kalnichevski

  • HTTPCLIENT-2262: Corrected RequestConfig#connectionRequestTimeout Javadoc. Contributed by Oleg Kalnichevski

  • Pass HttpContext to SSLConnectionSocketFactory#prepareSocket method (#404). Contributed by Alen Turkovic

  • Bump jna.version from 5.12.1 to 5.13.0 #407. Contributed by Dependabot and Gary Gregory

Commits
  • 57f6927 HttpClient 5.2.2 release
  • 4a3928d Updated release notes for HttpClient 5.2.2 release
  • 32ce98d HTTPCLIENT-2302: Add comment to TrustStrategy usage in examples (#492)
  • 6105852 More consistent handling of OperationTimeoutException in MemcachedHttpCacheSt...
  • 5f46cde HTTPCLIENT-2300: abstract char message consumers to use UTF-8 by default if a...
  • 2bc3991 HTTPCLIENT-2299: Socket timeout value set via DefaultManagedHttpClientConnect...
  • b0a7fdc Upgraded HttpCore to version 5.2.3
  • 404a3ab HTTPCLIENT-2292: HttpClient ignores socketConfig#getSocksProxyAddress
  • 8da4783 HTTPCLIENT-2295 Fix links to Core Javadoc
  • 2236696 Check for timeToLive == 0
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [org.apache.httpcomponents.client5:httpclient5](https://github.com/apache/httpcomponents-client) from 5.2.1 to 5.2.2.
- [Changelog](https://github.com/apache/httpcomponents-client/blob/rel/v5.2.2/RELEASE_NOTES.txt)
- [Commits](apache/httpcomponents-client@rel/v5.2.1...rel/v5.2.2)

---
updated-dependencies:
- dependency-name: org.apache.httpcomponents.client5:httpclient5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 24, 2023
@davewichers
Copy link
Collaborator

@spassarop - This upgrade breaks something. Here's the error message:

[ERROR] org.owasp.validator.html.test.AntiSamyTest.testImportedStylesParsing -- Time elapsed: 0.007 s <<< ERROR!
java.lang.IllegalArgumentException: Invalid Proxy
at java.net.Socket.(Socket.java:125)
at org.apache.hc.client5.http.ssl.SSLConnectionSocketFactory.createSocket(SSLConnectionSocketFactory.java:208)
at org.apache.hc.client5.http.impl.io.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:158)
at org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:447)
at org.apache.hc.client5.http.impl.classic.InternalExecRuntime.connectEndpoint(InternalExecRuntime.java:162)
at org.apache.hc.client5.http.impl.classic.InternalExecRuntime.connectEndpoint(InternalExecRuntime.java:172)
at org.apache.hc.client5.http.impl.classic.ConnectExec.execute(ConnectExec.java:142)
at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
at org.apache.hc.client5.http.impl.classic.ProtocolExec.execute(ProtocolExec.java:192)
at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
at org.apache.hc.client5.http.impl.classic.ContentCompressionExec.execute(ContentCompressionExec.java:152)
at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
at org.apache.hc.client5.http.impl.classic.RedirectExec.execute(RedirectExec.java:115)
at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
at org.apache.hc.client5.http.impl.classic.InternalHttpClient.doExecute(InternalHttpClient.java:170)
at org.apache.hc.client5.http.impl.classic.CloseableHttpClient.execute(CloseableHttpClient.java:245)
at org.apache.hc.client5.http.impl.classic.CloseableHttpClient.execute(CloseableHttpClient.java:188)
at org.apache.hc.client5.http.impl.classic.CloseableHttpClient.execute(CloseableHttpClient.java:162)
at org.owasp.validator.css.CssScanner.parseImportedStylesheets(CssScanner.java:328)
at org.owasp.validator.css.CssScanner.getCleanStylesheetWithImports(CssScanner.java:229)
at org.owasp.validator.css.CssScanner.scanStyleSheet(CssScanner.java:178)
at org.owasp.validator.html.scan.AntiSamyDOMScanner.processStyleTag(AntiSamyDOMScanner.java:464)
at org.owasp.validator.html.scan.AntiSamyDOMScanner.actionValidate(AntiSamyDOMScanner.java:395)
at org.owasp.validator.html.scan.AntiSamyDOMScanner.recursiveValidateTag(AntiSamyDOMScanner.java:297)
at org.owasp.validator.html.scan.AntiSamyDOMScanner.processChildren(AntiSamyDOMScanner.java:711)
at org.owasp.validator.html.scan.AntiSamyDOMScanner.processChildren(AntiSamyDOMScanner.java:703)
at org.owasp.validator.html.scan.AntiSamyDOMScanner.scan(AntiSamyDOMScanner.java:177)
at org.owasp.validator.html.AntiSamy.scan(AntiSamy.java:127)
at org.owasp.validator.html.test.AntiSamyTest.testImportedStylesParsing(AntiSamyTest.java:2299)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
... more

When you get a moment, can you research to see if you can figure out how to fix this so we can upgrade?

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 4, 2023

Superseded by #400.

@dependabot dependabot bot closed this Dec 4, 2023
@dependabot dependabot bot deleted the dependabot/maven/org.apache.httpcomponents.client5-httpclient5-5.2.2 branch December 4, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant