Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support common CSS relative length units such as rem, vw, vh, etc #104

Merged
merged 1 commit into from
Sep 19, 2021

Conversation

LiuXing-R
Copy link
Contributor

Reason

<p style="width: 13rem;">This is text.</p>
Out 
<p style="">This is text.</p>

Want to support all relative length units?

@LiuXing-R LiuXing-R changed the title Support common CSS relative length units such as rpx, REM, VW, VH, etc Support common CSS relative length units such as rpx, rem, vw, vh, etc Aug 31, 2021
@davewichers
Copy link
Collaborator

@spassarop - What do you think about this proposed change?

@spassarop
Copy link
Collaborator

Batik CSS does the job understanding them as correct units, then it's up to us including them in the default policies or not.
It will do no harm and @LiuXing-R already did it, so it's ok. Although, I needed to check those units are supported by running code, so maybe @LiuXing-R could add or expand a test case having those "new" units.

@LiuXing-R
Copy link
Contributor Author

@spassarop - I found that there are two branches main and 1.6.5 in the community warehouse. I wonder which branch should I add modification and test cases in if the current modification and #102 will conflict with each other?

@spassarop
Copy link
Collaborator

spassarop commented Sep 11, 2021 via email

@LiuXing-R LiuXing-R changed the title Support common CSS relative length units such as rpx, rem, vw, vh, etc Support common CSS relative length units such as rem, vw, vh, etc Sep 13, 2021
@LiuXing-R
Copy link
Contributor Author

@spassarop Added a use case.
So do I need to merge PR into branch 1.6.5?

@spassarop
Copy link
Collaborator

spassarop commented Sep 13, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants