-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support common CSS relative length units such as rem, vw, vh, etc #104
Conversation
@spassarop - What do you think about this proposed change? |
Batik CSS does the job understanding them as correct units, then it's up to us including them in the default policies or not. |
@spassarop - I found that there are two branches |
Now that you mention it, since my first collaborations on this project we
tend to use a branch representing the next release so new PRs should be
targeting 1.6.5. If a conflict emerges, it will be solved when the time
comes. In this case I guess the conflict may be on the policy lines of the
positive length regex, a simple merge.
…On Sat, 11 Sep 2021 at 04:12 star-r ***@***.***> wrote:
@spassarop <https://github.com/spassarop> - I found that there are two
branches main and 1.6.5 in the community warehouse. I wonder which branch
should I add modification and test cases in if the current modification and
#102 <#102> will conflict with
each other?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#104 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHL3BMMBSBJF5KRFKG2QFWLUBL6PPANCNFSM5DDIQDLA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
1c626be
to
5d7ac03
Compare
@spassarop Added a use case. |
Yes, just edit the PR and change the target branch.
…On Mon, 13 Sep 2021 at 04:59 star-r ***@***.***> wrote:
@spassarop <https://github.com/spassarop> Added a use case.
So do I need to merge PR into branch 1.6.5?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#104 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHL3BMNHKJOOHTCXNFO3RCLUBWVM5ANCNFSM5DDIQDLA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
5d7ac03
to
4606bc7
Compare
Reason
Want to support all relative length units?