Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul向nacos同步时,nacos的groupName不是DEFAULT_GROUP ,在consul下线的实例的时候 对应的nacos实例没有下线 #327

Open
wenlong139 opened this issue Jun 21, 2023 · 1 comment

Comments

@wenlong139
Copy link

问题现象:nacos-sync管理后台配置的同步任务 分组名称填写了自己设置的值:
image
原因是nacos-sync的bug nacos-sync在获取 nacos实例列表的时候 使用的是上面这个 没传groupName的方法,导致获取到的实例列表为空,也就是对应groupName的实例列表没有获取到,所以没有执行删除实例的逻辑
image
应该用第二个方法

wenlong139 pushed a commit to wenlong139/nacos-sync that referenced this issue Jun 21, 2023
@zrlw
Copy link
Contributor

zrlw commented Nov 4, 2023

@wenlong139 修订内容应该没有问题,过了5个月了也没有合并,是不是要先提PR到develop分支?
@paderlol 还在么?

nacos-sync是不是近期没有Committer来review代码了?
@chuntaojun @xuechaos @binbin0325 @SpecialYang @li-xiao-shuang @HaojunRen @realJackSun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants