Make sensitivity of is_vulnerable_to_client_renegotiation_dos configurable #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxsasha
force-pushed
the
configurable-renegotiation-limit
branch
from
c7dee9a
to
9775655
Compare
mxsasha
force-pushed
the
configurable-renegotiation-limit
branch
from
9775655
to
f262aa8
Compare
|
Hello ! Thanks for the contribution, and nice catch on using an One last request : could you add a simple test that just ensures that Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying renegotiation multiple times to find mitigations makes sense. However, it is quite rare for servers to allow 1 but not too many renegotiations. For my use, I want to test compliance with requirements that do not allow it at all. Therefore, I'd like it to be configurable.