Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of the Dockerfile #654

Open
wants to merge 1 commit into
base: release
Choose a base branch
from

Conversation

Proto1337
Copy link

This PR will change up the Dockerfile a bit. The most important changes can be summarized as:

  • Bump Python version 3.9 -> 3.12
  • Add ability to specify Python version as build argument
  • Use a 2-stage-build with virtual environment
    • Build in stage 0
    • Execute in stage 1
  • Do not call setup.py anymore, instead use pip install
  • Remove installation of sudo which seems to do nothing
  • Add .git folder to .dockerignore

Considering that Python 3.9 is EOL next year's October I changed the default Python version to 3.12. Another version can simply be set when building with the "--build-arg" parameter like "--build-arg PYTHON_VERSION='3.11'" to use Python 3.11.
The usage of the venv and adding it to PATH eliminates the need to call sslyze with "python -m sslyze" and lets you call it directly with just "sslyze".

* Bump Python version 3.9 -> 3.12
* Add ability to specify Python version as build argument
* Use a 2-stage-build with virtual environment
    * Build in stage 0
    * Execute in stage 1
* Do not call setup.py anymore, instead use pip install
* Remove installation of sudo which seems to do nothing
* Add .git folder to .dockerignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant