Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename env var in allowed env #49

Closed
wants to merge 1 commit into from

Conversation

tomi
Copy link
Contributor

@tomi tomi commented Dec 3, 2024

  • N8N_RUNNERS_N8N_URI to N8N_RUNNERS_TASK_BROKER_URI.
  • N8N_LAUNCHER_HEALTH_CHECK_PORT to N8N_RUNNERS_LAUNCHER_HEALTH_CHECK_PORT
  • N8N_LAUNCHER_LOG_LEVEL to N8N_RUNNERS_LAUNCHER_LOG_LEVEL

Related to PR n8n-io/n8n#12017

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/config/config.go 0.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

- `N8N_RUNNERS_N8N_URI` to `N8N_RUNNERS_TASK_BROKER_URI`.
- `N8N_LAUNCHER_HEALTH_CHECK_PORT` to `N8N_RUNNERS_LAUNCHER_HEALTH_CHECK_PORT`
- `N8N_LAUNCHER_LOG_LEVEL` to `N8N_RUNNERS_LAUNCHER_LOG_LEVEL`

Related to PR n8n-io/n8n#12017
@tomi tomi force-pushed the refactor-rename-allowed-env-var branch from e70caeb to 70b0539 Compare December 3, 2024 10:53
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

Once all the renamings are merged on both sides, I'll retest to double check.

@tomi
Copy link
Contributor Author

tomi commented Dec 4, 2024

Closed in favor of #52

@tomi tomi closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants