Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce client-side TypeScript LSP #9908

Closed
wants to merge 2 commits into from

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jul 2, 2024

Experiment to let Codemirror source typings, completions, diagnostics, doclines, usw. from a client-side TS LSP server running in a VFS environment, similar to TS Playground.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jul 2, 2024
@@ -368,4 +371,32 @@ export class FrontendService {
}
}
}

async generateTypedefs() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we not generate these at build instead of doing it at runtime?

@ivov
Copy link
Contributor Author

ivov commented Dec 19, 2024

Continued at #12285

@ivov ivov closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants