Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(API): Add route for schema static files #12770

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Jan 22, 2025

Summary

How to test:

  • http://localhost:5678/schemas/n8n-nodes-base.activeCampaign/1.0.0/account/get.json should return the correct schema
  • Other nodes, resources or operations should return 404
image

Frontend will be added in a next PR

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2216/load-the-schema-dynamically

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/cli/src/server.ts 0.00% 9 Missing ⚠️
packages/cli/src/load-nodes-and-credentials.ts 87.50% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@elsmr elsmr removed the request for review from ShireenMissi January 22, 2025 10:58
@@ -0,0 +1,110 @@
{
Copy link
Member

@netroy netroy Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we planning to auto-generate these schema files? if not, how do we keep these updated in the long run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants