-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix DB migration for older versions of MySQL #12328
Merged
burivuhster
merged 1 commit into
master
from
pay-2399-community-issue-migration-script-crash
Dec 20, 2024
Merged
chore: Fix DB migration for older versions of MySQL #12328
burivuhster
merged 1 commit into
master
from
pay-2399-community-issue-migration-script-crash
Dec 20, 2024
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Enhancement outside /nodes-base and /editor-ui
n8n team
Authored by the n8n team
labels
Dec 20, 2024
netroy
approved these changes
Dec 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
✅ All Cypress E2E specs passed |
n8n Run #8433
Run Properties:
|
Project |
n8n
|
Branch Review |
pay-2399-community-issue-migration-script-crash
|
Run status |
Passed #8433
|
Run duration | 04m 45s |
Commit |
0aa16c7c97: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 burivuhster 🗃️ e2e/*
|
Committer | Eugene Molodkin |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
480
|
View all changes introduced in this branch ↗︎ |
burivuhster
deleted the
pay-2399-community-issue-migration-script-crash
branch
December 20, 2024 11:38
riascho
pushed a commit
that referenced
this pull request
Dec 23, 2024
Got released with |
1 similar comment
Got released with |
Got released with |
1 similar comment
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MySQL does not support using literal constants as default values for JSON columns, but do support expressions (expression value can be literal).
Wrapping the default value for a column in parentheses improves compatibility (MySQL 8.0.13+) and does not affect other DBs.
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)