Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix DB migration for older versions of MySQL #12328

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

burivuhster
Copy link
Contributor

@burivuhster burivuhster commented Dec 20, 2024

Summary

MySQL does not support using literal constants as default values for JSON columns, but do support expressions (expression value can be literal).
Wrapping the default value for a column in parentheses improves compatibility (MySQL 8.0.13+) and does not affect other DBs.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Sorry, something went wrong.

@burivuhster burivuhster marked this pull request as ready for review December 20, 2024 11:00
@burivuhster burivuhster requested a review from a team as a code owner December 20, 2024 11:00
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Dec 20, 2024

n8n    Run #8433

Run Properties:  status check passed Passed #8433  •  git commit 0aa16c7c97: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 burivuhster 🗃️ e2e/*
Project n8n
Branch Review pay-2399-community-issue-migration-script-crash
Run status status check passed Passed #8433
Run duration 04m 45s
Commit git commit 0aa16c7c97: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 burivuhster 🗃️ e2e/*
Committer Eugene Molodkin
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 480
View all changes introduced in this branch ↗︎

@burivuhster burivuhster merged commit 2f21404 into master Dec 20, 2024
42 of 43 checks passed
@burivuhster burivuhster deleted the pay-2399-community-issue-migration-script-crash branch December 20, 2024 11:38
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.1

1 similar comment
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.1

@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.0

1 similar comment
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants