fix(Postgres PGVector Store Node): Do not initialize client to avoid idle connections #12318
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using
Postgres PGVector Store
to import a lot of documents, the Postgres server will deny connection after some items due to the number of clients :All of the Postgres clients are in
idle
state, waiting for the eventClientRead
.Test
Example workflow : Test_Postgres_PGVector_Store.json
SELECT count(1) FROM pg_stat_activity;
You should see more connection after the test without the patch, there here until the n8n server is terminated.
With the patch, you should get the same number of connections as the number at reset.
Related Linear tickets, Github issues, and Community forum posts
The fix is based of this comment of langchain-ai/langchainjs#5029.
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)