Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix serialization of circular json with task runner #12288

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

tomi
Copy link
Contributor

@tomi tomi commented Dec 18, 2024

Summary

Handle possible circular refs when serializing data to the task runner.

Based on a single benchmark run, this has no significant performance implication

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/CAT-433/community-issue-task-runner-timeout-when-testing-workflow-circular
#12235

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 🙏🏻

Do we need to backport this?

@tomi
Copy link
Contributor Author

tomi commented Dec 19, 2024

Do we need to backport this?

We probably can't make it to the release today, so yes

@tomi tomi added the release/backport Changes that need to be backported to older releases. label Dec 19, 2024
Copy link

cypress bot commented Dec 19, 2024

n8n    Run #8410

Run Properties:  status check passed Passed #8410  •  git commit 52bfd491bc: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 tomi 🗃️ e2e/*
Project n8n
Branch Review cat-433-task-runner-timeout-when-testing-workflow
Run status status check passed Passed #8410
Run duration 04m 37s
Commit git commit 52bfd491bc: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 tomi 🗃️ e2e/*
Committer Tomi Turtiainen
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 481
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit a99d726 into master Dec 19, 2024
37 checks passed
@ivov ivov deleted the cat-433-task-runner-timeout-when-testing-workflow branch December 19, 2024 08:55
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
@janober
Copy link
Member

janober commented Dec 19, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team release/backport Changes that need to be backported to older releases. Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants