Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HTTP Request Tool Node): Prevent creation of DynamicStructuredTool with empty schema #12269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OlegIvaniv
Copy link
Contributor

Summary

When using the HTTP Request Tool without any placeholders, an empty arguments schema was being generated. This caused compatibility issues with certain LLM providers (like Gemini) that enforce strict API validation requirements for tool schemas.

Solution

Added a condition to check if the HTTP Request Tool has any parameters (placeholders) defined:

  • If toolParameters.length > 0: Use N8nTool with the generated schema
  • If toolParameters.length === 0: Fall back to using DynamicTool without a schema

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant