refactor(core): Rename runner healthcheck env vars #12027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
ivov
reviewed
Dec 4, 2024
Comment on lines
14
to
16
| "N8N_RUNNERS_RUNNER_HEALTH_CHECK_SERVER_ENABLED", | ||
| "N8N_RUNNERS_RUNNER_HEALTH_CHECK_SERVER_HOST", | ||
| "N8N_RUNNERS_RUNNER_HEALTH_CHECK_SERVER_PORT", |
There was a problem hiding this comment.
As mentioned in the sister PR, these options take a repetitive infix _RUNNER_ but the ones above don't? I'd be for dropping this infix.
- `N8N_RUNNERS_SERVER_ENABLED` to `N8N_RUNNERS_HEALTH_CHECK_SERVER_ENABLED` - `N8N_RUNNERS_SERVER_HOST` to `N8N_RUNNERS_HEALTH_CHECK_SERVER_HOST` - `N8N_RUNNERS_SERVER_PORT` to `N8N_RUNNERS_HEALTH_CHECK_SERVER_PORT`
tomi
force-pushed
the
unify-runner-healthcheck-env-vars
branch
from
4a66bf7 to
2ba2d0c
Compare
tomi
added a commit
to n8n-io/task-runner-launcher
that referenced
this pull request
Dec 4, 2024
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
unify-runner-healthcheck-env-vars
|
| Run status |
|
| Run duration | 04m 41s |
| Commit |
|
| Committer | Tomi Turtiainen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
478
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
|
Closed in favor of #12040 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
N8N_RUNNERS_SERVER_ENABLEDtoN8N_RUNNERS_RUNNER_HEALTH_CHECK_SERVER_ENABLEDN8N_RUNNERS_SERVER_HOSTtoN8N_RUNNERS_RUNNER_HEALTH_CHECK_SERVER_HOSTN8N_RUNNERS_SERVER_PORTtoN8N_RUNNERS_RUNNER_HEALTH_CHECK_SERVER_PORTRelated PR: n8n-io/task-runner-launcher#50
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)