-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Make new canvas connections go underneath node when looping backwards #11833
Merged
alexgrozav
merged 6 commits into
master
from
n8n-7725-connections-loop-above-node-not-below-also-missing-arrow
Nov 25, 2024
Merged
feat(editor): Make new canvas connections go underneath node when looping backwards #11833
alexgrozav
merged 6 commits into
master
from
n8n-7725-connections-loop-above-node-not-below-also-missing-arrow
Nov 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
r00gm
approved these changes
Nov 25, 2024
n8n
|
Project |
n8n
|
Branch Review |
n8n-7725-connections-loop-above-node-not-below-also-missing-arrow
|
Run status |
|
Run duration | 04m 32s |
Commit |
|
Committer | Alex Grozav |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
478
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
Merged
Got released with |
riascho
pushed a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Old canvas:
![image](https://private-user-images.githubusercontent.com/6179477/388560776-086326ca-569c-437f-b6dc-52fc58d93805.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3Mjg0MjgsIm5iZiI6MTczOTcyODEyOCwicGF0aCI6Ii82MTc5NDc3LzM4ODU2MDc3Ni0wODYzMjZjYS01NjljLTQzN2YtYjZkYy01MmZjNThkOTM4MDUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTZUMTc0ODQ4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NzQ1YWZkMDk4MDk4ODM0NmZjOWUwZTlhZWUyOWRmZDYzY2FhZGVmMzJlODMwNDc1OWM5NjEwNmJkMjI2MDVhNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.nehFGH8pS1mkvNpNnHcm3W-elxPX2_sxHZdnlerr46c)
New canvas:
![image](https://private-user-images.githubusercontent.com/6179477/388561147-fb009f59-c652-43f6-9338-13391241d8a4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3Mjg0MjgsIm5iZiI6MTczOTcyODEyOCwicGF0aCI6Ii82MTc5NDc3LzM4ODU2MTE0Ny1mYjAwOWY1OS1jNjUyLTQzZjYtOTMzOC0xMzM5MTI0MWQ4YTQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTZUMTc0ODQ4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MjA5YTVmN2Q4YTlkNDMwMjA3NTJiNmY0NGNlYmIzYTI1MTZhOWJkMWU5Mjk5YjAyOGQyZDUyN2VmMTczNTg5YyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.5trNV3GqT7x05sZHgu2PDcdUqNArQfmMVH-V7E3iyaE)
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/N8N-7725/connections-loop-above-node-not-below-also-missing-arrow
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)