Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Make new canvas connections go underneath node when looping backwards #11833

Conversation

alexgrozav
Copy link
Member

@alexgrozav alexgrozav commented Nov 21, 2024

Summary

  • Loop connection underneath node when going backwards
  • Add arrow marker at first loop segment

Old canvas:
image

New canvas:
image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/N8N-7725/connections-loop-above-node-not-below-also-missing-arrow

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Nov 21, 2024
@alexgrozav alexgrozav changed the title feat(editor): Mmake new canvas connections go underneath node when looping backwards feat(editor): Make new canvas connections go underneath node when looping backwards Nov 21, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

cypress bot commented Nov 25, 2024

n8n    Run #8063

Run Properties:  status check passed Passed #8063  •  git commit 78f42c0648: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project n8n
Branch Review n8n-7725-connections-loop-above-node-not-below-also-missing-arrow
Run status status check passed Passed #8063
Run duration 04m 32s
Commit git commit 78f42c0648: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Committer Alex Grozav
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 478
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit 91d1bd8 into master Nov 25, 2024
35 checks passed
@alexgrozav alexgrozav deleted the n8n-7725-connections-loop-above-node-not-below-also-missing-arrow branch November 25, 2024 12:29
@github-actions github-actions bot mentioned this pull request Nov 27, 2024
@janober
Copy link
Member

janober commented Nov 27, 2024

Got released with [email protected]

riascho pushed a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants