Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Bring back execution data on the executionFinished push message #11821

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

netroy
Copy link
Member

@netroy netroy commented Nov 21, 2024

Summary

We removed the full execution data from the payload for executionFinished push message in #11703, because that serialization sometimes required quite a lot of memory.
This PR "temporarily" brings that data back, but now we instead serialize the data using flatted.stringify instead of JSON.stringify, which is a lot less expensive.

This change is still temporary, as we should instead improve the state management in the frontend to construct the final execution data based on all the partial data already delivered in the nodeExecuteAfter push messages.

Related Linear tickets, Github issues, and Community forum posts

PAY-2270

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 21, 2024
@netroy netroy force-pushed the PAY-2270-temporary-fix branch 3 times, most recently from 2a2374d to 4ffa63a Compare November 21, 2024 12:13
@netroy netroy added the release/backport Changes that need to be backported to older releases. label Nov 21, 2024
r00gm
r00gm previously approved these changes Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ges/editor-ui/src/composables/usePushConnection.ts 47.05% 9 Missing ⚠️
...ckages/cli/src/workflow-execute-additional-data.ts 16.66% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

despairblue
despairblue previously approved these changes Nov 21, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Nov 21, 2024

n8n    Run #8031

Run Properties:  status check failed Failed #8031  •  git commit f8674126cc: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project n8n
Branch Review PAY-2270-temporary-fix
Run status status check failed Failed #8031
Run duration 07m 24s
Commit git commit f8674126cc: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Committer कारतोफ्फेलस्क्रिप्ट™
View all properties for this run ↗︎

Test results
Tests that failed  Failures 6
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 319
View all changes introduced in this branch ↗︎

Tests for review

Failed  30-langchain.cy.ts • 5 failed tests

View Output Video

Test Artifacts
Langchain Integration > should be able to open and execute Basic LLM Chain node Screenshots Video
Langchain Integration > should be able to open and execute Agent node Screenshots Video
Langchain Integration > should add and use Manual Chat Trigger node together with Agent node Screenshots Video
Langchain Integration > should show tool info notice if no existing tools were used during execution Screenshots Video
Langchain Integration > should not show tool info notice if tools were used during execution Screenshots Video
Failed  19-execution.cy.ts • 1 failed test

View Output Video

Test Artifacts
Execution > should execute workflow partially up to the node that has issues Test Replay Screenshots Video
Failed  14-data-transformation-expressions.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  14-mapping.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  9-expression-editor-modal.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 45 specs in Cypress Cloud.

@netroy netroy dismissed stale reviews from despairblue and r00gm via ec53839 November 21, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team release/backport Changes that need to be backported to older releases. ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants