-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Bring back execution data on the executionFinished
push message
#11821
Open
netroy
wants to merge
4
commits into
master
Choose a base branch
from
PAY-2270-temporary-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+118
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Enhancement outside /nodes-base and /editor-ui
n8n team
Authored by the n8n team
ui
Enhancement in /editor-ui or /design-system
labels
Nov 21, 2024
netroy
force-pushed
the
PAY-2270-temporary-fix
branch
3 times, most recently
from
November 21, 2024 12:13
2a2374d
to
4ffa63a
Compare
netroy
force-pushed
the
PAY-2270-temporary-fix
branch
from
November 21, 2024 12:23
4ffa63a
to
f867412
Compare
netroy
added
the
release/backport
Changes that need to be backported to older releases.
label
Nov 21, 2024
r00gm
previously approved these changes
Nov 21, 2024
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
despairblue
reviewed
Nov 21, 2024
despairblue
previously approved these changes
Nov 21, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
core
Enhancement outside /nodes-base and /editor-ui
n8n team
Authored by the n8n team
release/backport
Changes that need to be backported to older releases.
ui
Enhancement in /editor-ui or /design-system
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We removed the full execution data from the payload for
executionFinished
push message in #11703, because that serialization sometimes required quite a lot of memory.This PR "temporarily" brings that data back, but now we instead serialize the data using
flatted.stringify
instead ofJSON.stringify
, which is a lot less expensive.This change is still temporary, as we should instead improve the state management in the frontend to construct the final execution data based on all the partial data already delivered in the
nodeExecuteAfter
push messages.Related Linear tickets, Github issues, and Community forum posts
PAY-2270
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)