Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Mark deprecations for v2 #11817

Merged
merged 13 commits into from
Nov 22, 2024
Merged

refactor(core): Mark deprecations for v2 #11817

merged 13 commits into from
Nov 22, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Nov 21, 2024 •
edited
Loading

Summary

Mark deprecations for N8N_BINARY_DATA_TTL, N8N_PERSISTED_BINARY_DATA_TTL, EXECUTIONS_DATA_PRUNE_TIMEOUT, N8N_BINARY_DATA_MODE as 'default', N8N_CONFIG_FILES, DB_TYPE as mysqldb or mariadb, and N8N_SKIP_WEBHOOK_DEREGISTRATION_SHUTDOWN.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Nov 21, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ackages/cli/src/deprecation/deprecation.service.ts 89.28% 2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

tomi
tomi reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea to make it its own service 👏 Some comments about wording mainly

packages/cli/src/deprecation/deprecation.service.ts Show resolved Hide resolved
packages/cli/src/deprecation/deprecation.service.ts Outdated Show resolved Hide resolved
packages/cli/src/deprecation/deprecation.service.ts Outdated Show resolved Hide resolved
packages/cli/src/deprecation/deprecation.service.ts Outdated Show resolved Hide resolved
packages/cli/src/deprecation/deprecation.service.ts Outdated Show resolved Hide resolved
packages/cli/src/deprecation/deprecation.service.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/start.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/base-command.ts Outdated Show resolved Hide resolved
packages/cli/src/deprecation/deprecation.service.ts Outdated Show resolved Hide resolved
@ivov
Copy link
Contributor Author

ivov commented Nov 21, 2024

@tomi Love your feedback as always! Please have another check when you can

@ivov ivov requested a review from tomi November 21, 2024 13:38
tomi
tomi previously approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cypress Cypress
Copy link

cypress bot commented Nov 21, 2024 •
edited
Loading

n8n    Run #8047

Run Properties:  status check passed Passed #8047  •  git commit e42ab4b340: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project n8n
Branch Review mark-deprecations-v2
Run status status check passed Passed #8047
Run duration 04m 41s
Commit git commit e42ab4b340: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Committer Iván Ovejero
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 478
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov requested a review from tomi November 21, 2024 14:45
tomi
tomi approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@ivov ivov requested a review from tomi November 22, 2024 11:15
@ivov
Copy link
Contributor Author

ivov commented Nov 22, 2024

@tomi Merged master to see if it helps with CI, if you can please reapprove

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit bce2366 into master Nov 22, 2024
35 checks passed
@ivov ivov deleted the mark-deprecations-v2 branch November 22, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomi tomi tomi approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivov @tomi