Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix some comments (no-changelog) #11816

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

binchengqu
Copy link
Contributor

@binchengqu binchengqu commented Nov 21, 2024

Summary

fix some comments

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added community Authored by a community member core Enhancement outside /nodes-base and /editor-ui ui Enhancement in /editor-ui or /design-system in linear Issue or PR has been created in Linear for internal review labels Nov 21, 2024
@Joffcom
Copy link
Member

Joffcom commented Nov 21, 2024

Hey @binchengqu,

Thanks for the PR, We have created "GHC-468" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

@csuermann csuermann changed the title chore(packages): fix some comments fix: fix some comments (no-changelog) Nov 21, 2024
@Joffcom Joffcom changed the title fix: fix some comments (no-changelog) fix: Fix some comments (no-changelog) Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@csuermann csuermann merged commit adf026c into n8n-io:master Nov 22, 2024
17 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member core Enhancement outside /nodes-base and /editor-ui in linear Issue or PR has been created in Linear for internal review ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants