Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add SolarWinds IPAM node credentials #11805

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Stamsy
Copy link
Contributor

@Stamsy Stamsy commented Nov 19, 2024

Summary

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2024

CLA assistant check
All committers have signed the CLA.

@Stamsy Stamsy changed the title Added SolarWinds IPAM node credentials WIP Added SolarWinds IPAM node credentials Nov 19, 2024
@n8n-assistant n8n-assistant bot added community Authored by a community member in linear Issue or PR has been created in Linear for internal review labels Nov 20, 2024
@Joffcom
Copy link
Member

Joffcom commented Nov 20, 2024

Hey @Stamsy,

Thanks for the PR, We have created "GHC-465" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...-base/credentials/SolarWindsIpamApi.credentials.ts 0.00% 9 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Stamsy Stamsy changed the title WIP Added SolarWinds IPAM node credentials Added SolarWinds IPAM node credentials Nov 20, 2024
@Stamsy Stamsy changed the title Added SolarWinds IPAM node credentials WIP Added SolarWinds IPAM node credentials Nov 20, 2024
@Stamsy Stamsy changed the title WIP Added SolarWinds IPAM node credentials Added SolarWinds IPAM node credentials Nov 20, 2024
@Stamsy Stamsy changed the title Added SolarWinds IPAM node credentials feat: Add SolarWinds IPAM node credentials Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants