fix(Chat Trigger Node): Return empty messages if loadPreviousSession and memory not connected #11787
+362
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Update import paths • Implement INodeType interface • Move handleFormData to separate function • Adjust webhook function implementation • Fix error handling and response formatting to always return empty array
OlegIvaniv
commented
Nov 19, 2024
| @@ -34,7 +36,69 @@ const allowedFileMimeTypeOption: INodeProperties = { | |||
| 'Allowed file types for upload. Comma-separated list of <a href="https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Common_types" target="_blank">MIME types</a>.', | |||
| }; | |||
|
|
|||
| export class ChatTrigger extends Node { | |||
| async function handleFormData(context: IWebhookFunctions) { | |||
There was a problem hiding this comment.
This is just moved from the class, not new
- Test webhook setup and execution - Add file upload handling tests - Test previous session loading - Mock memory and error scenarios - Update TriggerHelpers for input connection
OlegIvaniv
force-pushed
the
ai-458-community-issue-n8nchat-loadprevioussession-returns-500
branch
from
29bb57e
to
201e510
Compare
n8n-assistant
bot
added
n8n team
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the ChatTrigger node to improve error handling and adds some test coverage.
Changes
ChatTriggerclass to implementINodeTypeinstead of extendingNodeto be better testablehandleFormDatato a standalone function for better modularity and due to "this" naming req. of INodeType context argumentRelated Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)